feat: error handling #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oskardotglobal
added
enhancement
for more information, see https://pre-commit.ci
|
This is ready for review now with #26 being merged |
|
@oskardotglobal seems like something messed up with your repo, because it for example readds the quickemu installer script. |
|
Yeah, gotta merge first |
|
Ok, this is fully up-to-date now. |
LDprg
requested changes
Oct 9, 2023
|
Ok I've made some more changes; I've fully removed the |
|
there we go |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All those
.expects and nested match statements were bugging me, so I've written a custom error handler.Basically, I've written 2 macros, which do the following:
unwrap_or_panic!&unwrap_or_exit!- Unwrap either an Option or a Result. Log the error of the result if it exists + further context withformat!syntax supporterror!&error_from!- Construct aWinappsErrorfrom an existing error and / or a message. This is mostly used to return values from functions, but you can still callpanicandexiton it for the functionality of the 2 macros aboveI've also documented all of them and all the structs, enums and traits I used.
This also includes the commits from #26, so that has to be merged first.